Set NetNsId to -1 when attr is not specified #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks for the review, what is the next step to see it merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute is not specified on interfaces not tied to a specific network namespace and so it is not present in the netlink message. When it is the case,
LinkDeserializedoes not deserialize anything in thebase.NetNsIdfield and the default value ofbase.NetNsIdis 0. However, 0 is also a valid value for an existing netns id. Because of this, there is no way to know if the netns was not specified or if it is currently the existing netns with the id 0.This PR defaults the netns id to -1 so there is no more confusion (which is also the default value returned by your
netnslibrary when returning a non existingNsHandle).