Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide handle Close() and deprecate Delete() #689

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Provide handle Close() and deprecate Delete() #689

merged 1 commit into from
Sep 18, 2021

Conversation

thediveo
Copy link
Contributor

@thediveo thediveo commented Sep 4, 2021 •
edited by aboch
Loading

  • issue [feature] uniform Handle.Close() #682
  • provides a new Close method on netlink handles and deprecates the existing Delete method.
  • Refactors other code including unit tests to use the new Close method.

Closes #682

@aboch
Copy link
Collaborator

aboch commented Sep 17, 2021

pls rebase and force push so that CI (now fixed) will be triggered

@thediveo
Copy link
Contributor Author

Done. Hopefully that is now what you want and need?

@aboch
Copy link
Collaborator

aboch commented Sep 18, 2021

LGTM

@aboch aboch merged commit 626202e into vishvananda:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] uniform Handle.Close()
2 participants
@thediveo @aboch