Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the allmulticast option as own link attribute #635

Merged
merged 1 commit into from
May 8, 2021

Conversation

bjosv
Copy link
Contributor

@bjosv bjosv commented Apr 7, 2021

The ip link option allmulticast enables or disables the reception of all hardware multicast packets.

This PR provide the status of the allmulticast option via a highlevel link attribute instead of requiring raw flag handling. This also hides the dependencies to platform specific files for the user of this library.

Provide the status of the allmulticast option via the highlevel
link attributes instead of requiring raw flag handling.

Avoid comparing all rawflags before and after in tests due to that
the IFF_RUNNING flag might change independenly.

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Copy link
Contributor Author

bjosv commented Apr 26, 2021

Updated testcase TestLinkSetAllmulticast to avoid intermittent faults due to independently changed flag IFF_RUNNING by OS.
Can be seen at https://github.com/vishvananda/netlink/runs/2403394603 for PR #646

@aboch aboch merged commit 6063cc6 into vishvananda:master May 8, 2021
@bjosv bjosv deleted the add-allmulti-linkattrs branch May 10, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants