Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ip route append #619

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Add ip route append #619

merged 1 commit into from
Mar 15, 2021

Conversation

yaocw2020
Copy link
Contributor

@yaocw2020 yaocw2020 commented Mar 10, 2021 •
edited
Loading

Add ip route append, equivalent to: ip route append $route

Signed-off-by: yaocw2020 yaocanwu@gmail.com

@yaocw2020
Copy link
Contributor Author

yaocw2020 commented Mar 10, 2021 •
edited
Loading

Fix: #539

@yaocw2020
Copy link
Contributor Author

Go test result

$ go test -v . -run TestRouteAppend
=== RUN   TestRouteAppend
--- PASS: TestRouteAppend (0.00s)
PASS
ok  	github.com/vishvananda/netlink	(cached)

@yaocw2020
Copy link
Contributor Author

@aboch We use netlink to implement Harvester network controller. We found that RouteAdd and RouteReplace can not meet the requirements, while ip route append $route can. Please review this PR, thanks!

aboch
aboch approved these changes Mar 14, 2021
View reviewed changes
route_test.go Outdated Show resolved Hide resolved
@yaocw2020
Add ip route append
d70ac58 
Signed-off-by: yaocw2020 <yaocanwu@gmail.com>
@aboch
Copy link
Collaborator

aboch commented Mar 15, 2021

LGTM

@aboch aboch merged commit c30d9bc into vishvananda:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboch aboch aboch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaocw2020 @aboch