Optimizations #597
Open
Optimizations #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboch
reviewed
Nov 23, 2020
| @@ -362,46 +362,44 @@ func (a *RtAttr) Serialize() []byte { | |||
|
|
|||
| type NetlinkRequest struct { | |||
There was a problem hiding this comment.
This is an exported type. Other project may already be using it and the members you are removing are unfortunately exported as well.
| func (req *NetlinkRequest) AddData(data NetlinkRequestData) { | ||
| req.Data = append(req.Data, data) | ||
| // AddRtAttr adds an RtAttr to the request | ||
| func (req *NetlinkRequest) AddRtAttr(attrType int, data []byte) *NetlinkRequest { |
There was a problem hiding this comment.
This one also changes existing exported methods.
aboch
reviewed
Nov 23, 2020
|
Looks like the Travis failed at the same test as in #581 |
|
pls fix conflicts |
|
ping... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.