Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for RTA_VIA #585

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Adding support for RTA_VIA #585

merged 1 commit into from
Dec 3, 2020

Conversation

fach
Copy link
Contributor

@fach fach commented Oct 29, 2020

RTA_VIA is the netlink attribute type used to specify a gateway for a route using a different address family than said route. An example of this is using a IPv4 next hop for an IPv6 route. This PR adds support to set/get routes containing the RTA netlink attribute type.

Signed-off-by: Steve Shaw shaw38@gmail.com

@aboch
Copy link
Collaborator

aboch commented Nov 22, 2020

Can you please add or extend existing UT functions to test the programming and reading of the via setting

route_test.go Outdated Show resolved Hide resolved
route_test.go Outdated Show resolved Hide resolved
@aboch
Copy link
Collaborator

aboch commented Dec 3, 2020

Thanks @fach please squash your commits into one and force push.

Signed-off-by: Steve Shaw <shaw38@gmail.com>
@fach
Copy link
Contributor Author

fach commented Dec 3, 2020

Tests were failing due to the kernel version on the test runner. Added minimum kernel version to the unit tests for this.

@aboch aboch merged commit fbe6077 into vishvananda:master Dec 3, 2020
@fach fach mentioned this pull request Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants