-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed endianity problem with Geneve tunnel VNI #582
Conversation
Test failure is because the tests are running on ubuntu 16.04 where iproute2 doesn't support dstport for Geneve. So the options are:
|
can you try modifying the travis config in your branch to use a newer version of ubuntu? That way we can see if any other tests start failing. |
Doesn't look good, we have problems with modprobe nf_conntrack_ipv4 and qdisc |
Pull request was changes so we don't attempt to explicitly set the distort. It rely (and verify) the implicit Geneve port so we don't actually loose a lot in testing. |
please rebase |
Most of the support was done in a separate commit, but the endianity problem need to be fixed |
Thanks. |
2. Parse remote IP 3. Added unit test to test geneve paramters against "ip link"
LGTM |
It seems that VNI (ID in the code) is passed in host order.
The change include tests to verify that we use the correct endianity: It create a tunnel using
ip link
and read the ID of that tunnel proving that reading has the correct endianity. The test that set and read proves that the write endianity is the same as the read.