Fixes Issue #509 more generically #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoracek
added a commit
to phoracek/bridge-marker
that referenced
this pull request
Jan 19, 2022
This patch brings in the latest version of vishvananda/netlink in order to address kubevirt#45 through vishvananda/netlink#549. Since there is no new tagged version since 1.1.0, we are forced to pin to a specific commit. Signed-off-by: Petr Horáček <phoracek@redhat.com>
kubevirt-bot
pushed a commit
to kubevirt-bot/bridge-marker
that referenced
this pull request
Jun 1, 2022
This patch brings in the latest version of vishvananda/netlink in order to address kubevirt#45 through vishvananda/netlink#549. Since there is no new tagged version since 1.1.0, we are forced to pin to a specific commit. Signed-off-by: Petr Horáček <phoracek@redhat.com>
kubevirt-bot
added a commit
to kubevirt/bridge-marker
that referenced
this pull request
Jun 2, 2022
This patch brings in the latest version of vishvananda/netlink in order to address #45 through vishvananda/netlink#549. Since there is no new tagged version since 1.1.0, we are forced to pin to a specific commit. Signed-off-by: Petr Horáček <phoracek@redhat.com> Co-authored-by: Petr Horáček <phoracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix #512 apparently didn't solve all cases. This generically
skips values that are null to solve the problem. Also closes #548.