Add LinkModify support #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add a UT for this. |
Signed-off-by: Daniel Gollub <dgollub@att.com>
|
Added a UT for LinkModify which creates a Dummy interface and updates/modifies the MTU. |
|
LGTM |
tobias-urdin
added a commit
to tobias-urdin/netlink
that referenced
this pull request
Sep 30, 2021
When the LinkModify was merged in [1] a function that exports it outside of pkgHandle was never added like is available for LinkAdd, LinkDel etc. Update testing to use exported LinkModify that itself calls the pkgHandle.LinkModify function. [1] vishvananda#541
aboch
pushed a commit
that referenced
this pull request
Nov 18, 2021
When the LinkModify was merged in [1] a function that exports it outside of pkgHandle was never added like is available for LinkAdd, LinkDel etc. Update testing to use exported LinkModify that itself calls the pkgHandle.LinkModify function. [1] #541
cyberys
pushed a commit
to cyberys/netlink
that referenced
this pull request
Apr 5, 2022
When the LinkModify was merged in [1] a function that exports it outside of pkgHandle was never added like is available for LinkAdd, LinkDel etc. Update testing to use exported LinkModify that itself calls the pkgHandle.LinkModify function. [1] vishvananda#541
cjmakes
pushed a commit
to cjmakes/netlink
that referenced
this pull request
Jun 29, 2022
When the LinkModify was merged in [1] a function that exports it outside of pkgHandle was never added like is available for LinkAdd, LinkDel etc. Update testing to use exported LinkModify that itself calls the pkgHandle.LinkModify function. [1] vishvananda#541
deepakkumarbhagat
pushed a commit
to deepakkumarbhagat/netlink
that referenced
this pull request
Jun 15, 2023
When the LinkModify was merged in [1] a function that exports it outside of pkgHandle was never added like is available for LinkAdd, LinkDel etc. Update testing to use exported LinkModify that itself calls the pkgHandle.LinkModify function. [1] vishvananda#541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Gollub dgollub@att.com