make tuntap pollable #525
Merged
make tuntap pollable #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishvananda is there anything that I can help with to expedite this PR? Or any questions around this? |
|
@vishvananda ping... thanks for considering |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch allows tuntaps to be used with go1.13. It worked w/ 1.12 and before. Then failed with 1.13 resulting in
read /dev/net/tun: not pollable.The comment in the code has additional details. Thanks to @breakintheweb for the help to fix this.
See golang/go#30426 which got exposed in go 1.13 by the fix to golang/go#30624 .