Introduce RouteGetWithOptions that allows to modify the RouteGet #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for VrfName as the RouteGetOptions Signed-off-by: Amit Nishry <amit.nishry@gmail.com>
aboch
reviewed
Feb 10, 2020
| func (h *Handle) RouteGet(destination net.IP) ([]Route, error) { | ||
| // RouteGetWithOptions gets a route to a specific destination from the host system. | ||
| // Equivalent to: 'ip route get <> vrf <VrfName>'. | ||
| func (h *Handle) RouteGetWithOptions(destination net.IP, options *RouteGetOptions) ([]Route, error) { |
There was a problem hiding this comment.
I am not against this approach, was just thinking that if we add variadic options to existing function instead:
func (h *Handle) RouteGet(destination net.IP, options...RouteOption) ([]Route, error)
then we can avoid adding a new method.
There was a problem hiding this comment.
totally forgot that it is an option, too much C
|
Having an explicit method for querying a route with options is not that bad either. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for VrfName as the RouteGetOptions
Signed-off-by: Amit Nishry amit.nishry@gmail.com