Restrict notifyDriverOfPrototypeAndBehaviorProps to 3D nodes #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Virtually all of the threejs driver functions should have an early exit if the node doesn't map to a three.js node. |
BrettASwift
added a commit
that referenced
this pull request
Jan 25, 2016
…iver-props-performance Restrict notifyDriverOfPrototypeAndBehaviorProps to 3D nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davideaster @kadst43
David, I tested what nodes this portion of the code was hitting by checking for
!node || !node.threeObjectand all of the child ids it spit out were not important to the driver, so I added the check for node and threeObject. The result was a total load time improvement of 6 seconds on my lap top (~28s down to ~22s). The scene remains intact and the game is playable. I didn't notice any issue in testing. Is there any obvious issue I am missing here or does this do the trick?