-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mars Game Optimization Tests #495
Mars Game Optimization Tests #495
Conversation
Are we sure those are new with David's changes? Or were they introduced with some of Brett's shader changes recently? |
(In any case, 👍. Let's get it in so we can start testing with it) |
Odd. I can't think of how this might break WebGL. Maybe it's related to the threes.js changes where properties are pulled up from the prototypes. |
Dont think we've merged in the shader changes yet - Ive seen the "loop unroll" error intermittently before but never the shadow/GL Errors... anyway - merging |
…ion-tests-mars-game Mars Game Optimization Tests
Shader changes are definitely merged - at least some of them are. The video of the animated shader that's up on Redmine was made in mars-game-development. |
Ah ok - was just looking at the open PR :) |
@kadst43 @BrettASwift @davideaster
Seeing some new errors/warnings... notably:
(ERROR) Unsupported light type for shadowrender @ three.js:25381
(WARNING) @ three.js:24586 THREE.WebGLProgram: gl.getProgramInfoLog() (90,7-102): warning X3557: loop only executes for 1 iteration(s), forcing loop to unroll
(117,7-102): warning X3557: loop only executes for 1 iteration(s), forcing loop to unroll
(WARNING) @ three.js:24586 THREE.WebGLProgram: gl.getProgramInfoLog() (88,7-102): warning X3557: loop only executes for 1 iteration(s), forcing loop to unroll
(108,7-102): warning X3557: loop only executes for 1 iteration(s), forcing loop to unroll
(WARNING) @ localhost/:1 [.WebGLRenderingContext-00000000054A98E0]GL ERROR :GL_INVALID_OPERATION : glDrawElements: range out of bounds for buffer (x 256)
...
That said, load times seem drastically improved and two rovers executing at once is feasible. Still some slowdown over time / with 3 executing at once. Camera movement seems smoother. Thanks to David for changes.