viogpu: Decouple DBG from WPP #1042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozenfe
approved these changes
Feb 14, 2024
| @@ -3411,6 +3411,8 @@ BOOLEAN VioGpuAdapter::CreateCursor(_In_ CONST DXGKARG_SETPOINTERSHAPE* pSetPoin | |||
| UINT resid, format, size; | |||
| VioGpuObj* obj; | |||
| PAGED_CODE(); | |||
| (void)pSetPointerShape; // unused | |||
There was a problem hiding this comment.
Sorry, why those two are added in this commit?
There was a problem hiding this comment.
Because those variables are not used. They are only referenced with DbgPrint but when you build non-debug build where it's no-op you'll get compiler warning so by this we silence that warning.
|
@kostyanf14 Win2022x64 has two DF tests failing. Looks like something new, no? |
|
@YanVugenfirer Yes, two DF tests failing is a new one. I restarted the tests but it failed again in both PRs. Need to investigate the reason. Error occurs only in Win2022. |
Previously !DBG meant event tracing which can be confusing Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
!DBGmeant event tracing which can be confusing.Now with this PR it's possible to build these combinations:
DBG 1- debug buildEVENT_TRACING 1- WPP build (default)