-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viogpu: Decouple DBG from WPP #1042
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you.
Vadim.
@@ -3411,6 +3411,8 @@ BOOLEAN VioGpuAdapter::CreateCursor(_In_ CONST DXGKARG_SETPOINTERSHAPE* pSetPoin | |||
UINT resid, format, size; | |||
VioGpuObj* obj; | |||
PAGED_CODE(); | |||
(void)pSetPointerShape; // unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, why those two are added in this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because those variables are not used. They are only referenced with DbgPrint
but when you build non-debug build where it's no-op you'll get compiler warning so by this we silence that warning.
@kostyanf14 Win2022x64 has two DF tests failing. Looks like something new, no? |
@YanVugenfirer Yes, two DF tests failing is a new one. I restarted the tests but it failed again in both PRs. Need to investigate the reason. Error occurs only in Win2022. |
Previously !DBG meant event tracing which can be confusing Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
rerun tests |
Previously
!DBG
meant event tracing which can be confusing.Now with this PR it's possible to build these combinations:
DBG 1
- debug buildEVENT_TRACING 1
- WPP build (default)