Adds test for duplicate quotes #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mocha & chai for tests - duplicate quotes are output to local file for review
vinitshahdeo
added
new-quote
|
@nessieSnippets Thanks for the PR. I'll review and merge it soon.
✅ Link to the repository |
vinitshahdeo
added
for-new-contributors
Purukitto
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Mocha for tests - trying to keep inline with Issue #257 & the PRs already raised for that.
Uses Javascript Set to test if all entries are unique. Quotes are lowercased, punctuation stripped before checks.
Duplicate quotes are output to local file for review
Thoughts / feedback much appreciated if this is a useful approach 😄