use lock to fix race condition in cache #8240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple psalm instances in the same directory (e.g. I want to analyze 2 distinct directories or X files only) at the same time (e.g. CI pipeline), I was getting random "Unexpected value when loading from file content hashes" errors due to race conditions
By using a read/write lock with wait this issue is resolved.
The "write" lock success is not checked, since this issue only happens with simultaneous runs which means the data of multiple writes at the same time the file is locked is the same that is currently being written.