Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name property of enum cases return non-empty-strings #7077

Conversation

ricardoboss
Copy link
Contributor

This is a follow-up for #6964 since the changes made there didn't have the desired outcome.

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 5, 2021
@weirdan weirdan merged commit 4a35a85 into vimeo:master Dec 5, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 5, 2021

Thanks!

@ricardoboss ricardoboss deleted the issue-6964-refinement-unitenum-name-property branch December 6, 2021 02:02
ricardoboss added a commit to elephox-dev/framework that referenced this pull request Dec 8, 2021
ricardoboss added a commit to elephox-dev/logging that referenced this pull request Dec 8, 2021
ricardoboss added a commit to elephox-dev/http that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants