fix other places that have a similar bug

vimeo · Dec 18, 2023 · a8e072a · a8e072a
1 parent f8a53eb
commit a8e072a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Psalm/Codebase.php b/src/Psalm/Codebase.php
@@ -1688,7 +1688,7 @@ public function getSignatureInformation(
                 if (InternalCallMapHandler::inCallMap($function_symbol)) {
                     $callables = InternalCallMapHandler::getCallablesFromCallMap($function_symbol);
 
-                    if (!$callables || !$callables[0]->params) {
+                    if (!$callables || !isset($callables[0]->params)) {
                         return null;
                     }
 
@@ -1838,7 +1838,7 @@ public function getBeginedLiteralPart(string $file_path, Position $position): st
         $offset = $position->toOffset($file_contents);
 
         preg_match('/\$?\w+$/', substr($file_contents, 0, $offset), $matches);
-        
+
         return $matches[0] ?? '';
     }
 
@@ -1857,7 +1857,7 @@ public function getTypeContextAtPosition(string $file_path, Position $position):
             }
             // First parameter to a function-like
             $function_storage = $this->getFunctionStorageForSymbol($file_path, $function . '()');
-            if (!$function_storage || !$function_storage->params || !isset($function_storage->params[$argument_num])) {
+            if (!$function_storage || !isset($function_storage->params) || !isset($function_storage->params[$argument_num])) {
                 return null;
             }
 
@@ -1957,7 +1957,7 @@ public function getCompletionItemsForClassishThing(
                                 str_replace('$', '', $property_name),
                             );
                         }
-    
+
                         foreach ($class_storage->pseudo_property_set_types as $property_name => $type) {
                             $pseudo_property_types[$property_name] = new CompletionItem(
                                 str_replace('$', '', $property_name),
@@ -1969,7 +1969,7 @@ public function getCompletionItemsForClassishThing(
                                 str_replace('$', '', $property_name),
                             );
                         }
-    
+
                         $completion_items = [...$completion_items, ...array_values($pseudo_property_types)];
                     }
 

diff --git a/src/Psalm/Internal/Codebase/Functions.php b/src/Psalm/Internal/Codebase/Functions.php
@@ -466,7 +466,7 @@ public function isCallMapFunctionPure(
             null,
         );
 
-        if (!$function_callable->params
+        if (!isset($function_callable->params)
             || ($args !== null && count($args) === 0)
             || ($function_callable->return_type && $function_callable->return_type->isVoid())
         ) {