feat: make Layout setting cumulative #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `Layout` setting cannot be overriden anymore because it's now cumulative, see: - https://vike.dev/Layout#multiple-layouts - https://vike.dev/Layout#nested-layouts
pdanpdan
reviewed
Jun 13, 2024
|
I would go with a merge for this one (because it works as expected) and after that start tweaking |
👍 Let me know what you find and PR welcome. |
|
Let's release after we merge |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main commit: 346981c. (The other commits merely do some refactoring and add a nested layout example.)
Context:
Layoutcumulative vike-react#119@pdanpdan Do the changes to
createVueApp.tslook good to you? I did some refactoring. Btw. I've been wondering: how about we useshallowRef()instead ofrefinsidecreateVueApp.ts?