Fine tune blacklist handling

[mjneil]

Description

Currently it doesn't really matter whether a representation is disabled through user interaction via the representations api, or blacklisted internally because of network or playback errors. This can cause undefined references in our playlist selector (#1206 #1267) when whatever playlists have not been manually disabled are all blacklisted internally due to errors.

Specific Changes proposed

• never allow playlist selector to select a playlist that has been permanently blacklisted due to incompatible configuration
• When filtering playlists within the playlist selectors, if there are no enabled playlists (i.e. not blacklisted internally AND not disabled by the user) available, then fall back to using the list of playlists not disabled by the user regardless of blacklist state.
• make sure playlists blacklisted from an illegal media switch is permanently blacklisted, as there is no reason to try it again at a later time.
• The representation api will return a list that filters out just incompatible playlists instead of both incompatible playlists and temporary blacklisted playlists.

[OshinKaramian]

Minor test comments.

[OshinKaramian]

Might hit a merge conflict due to: #1271.

[mjneil]

Ya we'll just merge that one first and i can rebase this or vice versa

[OshinKaramian]

Could we maybe break this test up in some way? Maybe one for if playerlist.disabled is set to true? Or maybe based on the expectation (should be enabled vs should not be enabled)?

It also might be safer to not maintain the const playlist here and instead pass the raw values for playlist in. As an example:

playlist.excludeUntil = Date.now() - 1;
assert.ok(Playlist.isEnabled(playlist), 'playlist is enabled');

Just becomes:

assert.ok(Playlist.isEnabled({ excludeUntil: Date.now() - 1 }), 'playlist is enabled');

This way you don't need to worry about deleting things and the order of the tests won't matter.

[OshinKaramian]

Similar to my comment below, you could just get rid of const playlist and pass the raw values into the method under test.