Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with 3-5-2 #1457

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Align with 3-5-2 #1457

merged 9 commits into from
Dec 4, 2023

Conversation

dzianis-dashkevich
Copy link
Contributor

@dzianis-dashkevich dzianis-dashkevich commented Nov 30, 2023 •
edited
Loading

revert replaceSegemntsUntil
revert calculateTimestampOffsetForEachSegment

Dzianis Dashkevich added 7 commits November 29, 2023 20:27
Revert "fix: check for transmuxer for vtt-segment-loader (#1452)"
56fd59b 
This reverts commit b4dd748.
Revert "fix: fix several issues with calculate timestamp offset for e…
3a4d757 
…ach segment (#1451)"

This reverts commit 3bbc6ef.
Revert "fix: replaceSegmentsUntil flag resetting too early (#1444)"
6580dcf 
This reverts commit af39ba5.
Revert "fix: prevent wrapping in resetMainLoaderReplaceSegments (#1439)"
4d450e7 
This reverts commit 719b7f4.
Revert "feat: Add feature flag to calculate timestampOffset for each …
a4893f3 
…segment to handle streams with corrupted pts or dts timestamps (#1426)"

This reverts commit 2355ddc.
Revert "fix: fastQualityChange refactor (#1414)"
940d517 
This reverts commit 4590bdd.
cherry-pick: use transmuxer time info instead of probeTs
948df86
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5579b0) 86.14% compared to head (98dedca) 86.12%.
Report is 1 commits behind head on main.

❗ Current head 98dedca differs from pull request most recent head 6e6e6c4. Consider uploading reports for the commit 6e6e6c4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   86.14%   86.12%   -0.03%     
==========================================
  Files          42       42              
  Lines       10627    10586      -41     
  Branches     2450     2441       -9     
==========================================
- Hits         9155     9117      -38     
+ Misses       1472     1469       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich marked this pull request as ready for review November 30, 2023 01:57
@dzianis-dashkevich dzianis-dashkevich mentioned this pull request Nov 30, 2023
Closed
6 tasks
adrums86
adrums86 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense given a new sync strategy. :shipit:

@dzianis-dashkevich @wseymour15
feat: sync controller media sequence strategy (#1458)
6e6e6c4 
* feat: add media sequence sync strategy

* fix: fix current media sequence increment

* chore: update logs

* feat: use exact segment match in sync-controller

* fix: fix race condition for a fast quality switch

* chore: add additional logs for choose next request

* feat: force timestamp after resync

* chore: fix or skip tests

* Update src/segment-loader.js

Co-authored-by: Walter Seymour <walterseymour15@gmail.com>

---------

Co-authored-by: Dzianis Dashkevich <ddashkevich@brightcove.com>
Co-authored-by: Walter Seymour <walterseymour15@gmail.com>
@dzianis-dashkevich dzianis-dashkevich merged commit e304c20 into main Dec 4, 2023
7 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the align-3-5-2 branch December 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrums86 adrums86 adrums86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzianis-dashkevich @adrums86