refactor: drop support for the partial muxer #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 86.48% 86.16% -0.33%
==========================================
Files 39 39
Lines 9637 9252 -385
Branches 2182 2114 -68
==========================================
- Hits 8335 7972 -363
+ Misses 1302 1280 -22
Continue to review full report at Codecov.
|
35 tasks
gesinger
reviewed
Apr 20, 2021
| // if this is a partial transmux, the end of the timeline has not yet been reached | ||
| // until the last part of the segment is processed (at which point isPartial will | ||
| // be false) | ||
| isEndOfTimeline: isEndOfTimeline && !isPartial, |
There was a problem hiding this comment.
I think we still need isEndOfTimeline for #1058
There was a problem hiding this comment.
You are right, this was removed in error.
src/transmuxer-worker.js
Outdated
| } else { | ||
| wireFullTransmuxerEvents(this.self, this.transmuxer); | ||
| } | ||
| this.transmuxer = new FullMux(this.options); |
There was a problem hiding this comment.
Might be worth just calling it Transmuxer now.
src/transmuxer-worker.js
Outdated
|
|
||
| wireFullTransmuxerEvents(this.self, this.transmuxer); |
Co-authored-by: Garrett Singer <gesinger@gmail.com>
gesinger
previously approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to merge the partial muxer code into the non-partial muxer in mux.js, so we are removing the partial muxer option.