Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the wording of a warning. - VIDEOJS: WARN: Using hls options is deprecated. Use vhs instead. #1256

Closed
JamieDawson opened this issue Mar 1, 2022 · 6 comments · Fixed by #1257

Comments

@JamieDawson
Copy link

Please do not delete the template, by filling out the required information we can investigate your issue more quickly.

Before opening an issue see if your problem can be resolved with the troubleshooting guide.

Description

Briefly describe the issue.
Include a reduced test case, we have a starter template on JSBin you can use.

  • I get this deprecated warning in the console:
    VIDEOJS: WARN: Using hls options is deprecated. Use vhs instead.

This made me think I needed to call on the Getting Started code inside this repo

Sources

Is a certain source or a certain segment affected? please provide a public (accessible over the internet) link to it below.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Using HLS with videoJS
  2. Checking the console and seeing the deprecation warning.

Results

Expected

To use HLS with no warnings.

Error output

If there are any errors in the console, from the player, or anywhere else please include them here:
This is the warning I got in the console:
VIDEOJS: WARN: Using hls options is deprecated. Use vhs instead.

Additional Information

Please include any additional information necessary here. Including the following:
I was told by Gary Katsevman on the community Slack channel to make this issue so the wording can be improved.
https://videojs.slack.com/archives/C43LGP955/p1646171897832899

videojs-http-streaming version

what version of videojs-http-streaming does this occur with?
videojs-http-streaming 2.13.1

videojs version

what version of videojs does this occur with?
video.js 2.13.1

Browsers

what browsers are affected? please include browser and version for each

  • Chrome, Version 98.0.4758.109 (Official Build) (x86_64)

Platforms

what platforms are affected? please include operating system and version or device and version for each

  • macOS Montery Version 12.1
  • MacBook Pro (13-inch, 2020, Four Thunderbolt 3 ports)

Other Plugins

are any other videojs plugins being used on the page? If so, please list them with version below.
*No.

Other JavaScript

are you using any other javascript libraries or frameworks on the page? if so please list them below.

  • React
@welcome
Copy link

welcome bot commented Mar 1, 2022

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@matteocontrini
Copy link

Isn't this a bug? The warning is shown even if the hls option is not specified.

@gkatsev
Copy link
Member

gkatsev commented Jun 9, 2022

@matteocontrini can you provide a live minimal test case? Thanks!

@istng
Copy link

istng commented Jun 23, 2022

Hi! I quickly made this small codepen to show the warning, its shown on the browser console
https://codepen.io/istng/pen/YzemKZb
Let me know if this is what you were looking for!

@matteocontrini
Copy link

@gkatsev I then found out that it's the Mux Data plugin that makes use of that parameter even if I'm not using HLS. I'll report to them, there's probably no issue here.

@dee1cv
Copy link

dee1cv commented Jun 1, 2023

@istng Hi, yes i am facing that issue could you please please me with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants