Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DOM Event lint global false positive and access all window props explicitely #1756

Merged
merged 12 commits into from
Jun 8, 2018
Merged

Fix DOM Event lint global false positive and access all window props explicitely #1756

merged 12 commits into from
Jun 8, 2018

Commits on Jun 5, 2018

  1. eslintrc: don't have any explicit globals or env.browser preset globals 

    This has us have wrong positives, like "Event" not defined in effect
    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    1d58572 View commit details
    Browse the repository at this point in the history

  2. use explicite window property for all previous globals

    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    1f21784 View commit details
    Browse the repository at this point in the history

  3. lint script: add quiet mode (only show fatal errors)

    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    1baef80 View commit details
    Browse the repository at this point in the history

  4. Globals: Fix accessing worker window global scope

    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    b58112e View commit details
    Browse the repository at this point in the history

  5. Rever changes from #1755 since we did them in #1756 now

    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    ec44fb0 View commit details
    Browse the repository at this point in the history

  6. add getSelfScope to get global window/worker scope

    @tchakabam
    tchakabam committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    40bd49c View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. add getSelfScope to abstract from window/worker global scopes explici… 

    …tely
    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    461d220 View commit details
    Browse the repository at this point in the history

  2. decrypter: lint fix

    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    18be7d8 View commit details
    Browse the repository at this point in the history

  3. simplify get-self-scope module

    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    8d12a9a View commit details
    Browse the repository at this point in the history

  4. travis script: remove check for node require

    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    a4bdebf View commit details
    Browse the repository at this point in the history

  5. fix stream-controller unit-test not liking to grab performance ref on… 

    … module def
    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    4ac5420 View commit details
    Browse the repository at this point in the history

  6. stream controller test cosmetics

    @tchakabam
    tchakabam committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    77166d9 View commit details
    Browse the repository at this point in the history