refactor(function-rule): fail fast by checking potential failures and…

… quick returns first
vidavidorra · Apr 17, 2022 · c303b72 · c303b72
1 parent 8e09a33
commit c303b72
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/function-rule.ts b/src/function-rule.ts
@@ -15,11 +15,11 @@ const functionRule: Rule<FunctionRule> = (
   when: RuleConfigCondition = 'always',
   value: FunctionRule | undefined,
 ) => {
-  if (typeof value === 'function') {
-    return value(parsed, when);
+  if (typeof value !== 'function') {
+    throw new Error('Not a valid function!');
   }
 
-  throw new Error('Not a valid function!');
+  return value(parsed, when);
 };
 
 export default functionRule;