-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back compatibility with Scala 2.11 #50
Labels
Comments
Pushed 1.2.3-SNAPSHOT, available for Scala 2.11: https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/ Need to test that this works with Scala 2.11 and can merge into |
Merged
Addressed by #51. Version |
Hi Vic,
This is wonderful! I will give it a test from my side and let you know
the testing result.
Have wonderful weekends!
Max
…On Thu, Jun 18, 2020 at 11:46 PM Vic Kumar ***@***.***> wrote:
Pushed a 1.2.3-SNAPSHOT that is available for Scala 2.11:
https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/
Need to test that this works with Scala 2.11 and can merge into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ2USTX6UVDORJ4I35MOZ3RXLNRHANCNFSM4NY7MEKQ>
.
|
@mzhao577 Did the |
Hi Vic,
I just tested 1 case that I used most, the levenshstein distance and
score. It looks great.
I plan to run all the other tests listed in your GitHub testing cases. I
am doing it now. I will get you updated once I got it ran.
Max
…On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***> wrote:
@mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for
you with Scala 2.11?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ>
.
|
Thanks Max.
If you do add any more algorithms, please feel free to PR the repo if you
think they'd be useful to others.
I'll probably be doing a few more updates in a couple of weeks - nothing
heavy, just adding more documentation and maybe putting scalafmt to
auto-format all the files.
Appreciate it. Cheers.
Vic Kumar
vickumar@gmail.com
…On Sun, Jun 28, 2020 at 9:44 PM Max Zhao ***@***.***> wrote:
Hi Vic,
I just tested 1 case that I used most, the levenshstein distance and
score. It looks great.
I plan to run all the other tests listed in your GitHub testing cases. I
am doing it now. I will get you updated once I got it ran.
Max
On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***>
wrote:
> @mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for
> you with Scala 2.11?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#50 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ>
.
|
Hi Vic,
I was busy recently. I will do more testing once I get more free time.
Your code is very useful. Please keep it up!
If there are things I can do to help. Please do not hesitate to reach out
to me.
Thanks for your wonderful work!
Max
…On Mon, Jun 29, 2020 at 11:12 AM Vic Kumar ***@***.***> wrote:
Thanks Max.
If you do add any more algorithms, please feel free to PR the repo if you
think they'd be useful to others.
I'll probably be doing a few more updates in a couple of weeks - nothing
heavy, just adding more documentation and maybe putting scalafmt to
auto-format all the files.
Appreciate it. Cheers.
Vic Kumar
***@***.***
On Sun, Jun 28, 2020 at 9:44 PM Max Zhao ***@***.***> wrote:
> Hi Vic,
>
> I just tested 1 case that I used most, the levenshstein distance and
> score. It looks great.
>
> I plan to run all the other tests listed in your GitHub testing cases. I
> am doing it now. I will get you updated once I got it ran.
>
> Max
>
>
> On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***>
> wrote:
>
> > @mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for
> > you with Scala 2.11?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#50 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ
> >
> > .
> >
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <
#50 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ2USUZ4JEBFW7Q66TSLTTRZCVMLANCNFSM4NY7MEKQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spark EMR currently still uses the 2.11 compiler.
This commit: 7dfbb76 dropped support for 2.11.
Add back in compatibility with Scala 2.11
The text was updated successfully, but these errors were encountered: