Skip to content

Commit

Permalink
minor
Browse files Browse the repository at this point in the history
  • Loading branch information
vibhatha committed Jan 4, 2024
1 parent 51970e0 commit 3a2e808
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions cpp/src/arrow/array/array_binary_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "arrow/array/validate.h"
#include "arrow/buffer.h"
#include "arrow/memory_pool.h"
#include "arrow/result.h"
#include "arrow/status.h"
#include "arrow/testing/builder.h"
#include "arrow/testing/gtest_util.h"
Expand Down Expand Up @@ -393,7 +394,8 @@ TEST(StringViewArray, Validate) {

// empty array with some data buffers is valid
EXPECT_THAT(MakeBinaryViewArray({buffer_s, buffer_y}, {}), Ok());

ASSERT_OK_AND_ASSIGN(auto a1, MakeBinaryViewArray({buffer_s, buffer_y}, {}));
std::cout << a1->ToString() << std::endl;
// inline views need not have a corresponding buffer
EXPECT_THAT(MakeBinaryViewArray({},
{
Expand All @@ -402,14 +404,27 @@ TEST(StringViewArray, Validate) {
util::ToInlineBinaryView("inline me"),
}),
Ok());

ASSERT_OK_AND_ASSIGN(auto a2, MakeBinaryViewArray({buffer_s, buffer_y},
{
util::ToInlineBinaryView("hello"),
util::ToInlineBinaryView("world"),
util::ToInlineBinaryView("inline me"),
}));
std::cout << a2->ToString() << std::endl;
// non-inline views are expected to reference only buffers managed by the array
EXPECT_THAT(
MakeBinaryViewArray(
{buffer_s, buffer_y},
{util::ToBinaryView("supe", static_cast<int32_t>(buffer_s->size()), 0, 0),
util::ToBinaryView("yyyy", static_cast<int32_t>(buffer_y->size()), 1, 0)}),
Ok());
ASSERT_OK_AND_ASSIGN(auto a3, MakeBinaryViewArray(
{buffer_s, buffer_y},
{util::ToBinaryView("supe", static_cast<int32_t>(buffer_s->size()), 0, 0),
util::ToBinaryView("yyyy", static_cast<int32_t>(buffer_y->size()), 1, 0),
util::ToBinaryView("supe", static_cast<int32_t>(buffer_y->size()), 0, 0)}));
std::cout << buffer_s->size() << ", " << buffer_y->size() << std::endl;
std::cout << a3->ToString() << std::endl;

// views may not reference data buffers not present in the array
EXPECT_THAT(
Expand Down

0 comments on commit 3a2e808

Please sign in to comment.