Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default currency on transactions #5

Merged
merged 6 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,26 @@ jobs:
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
ruby-version: ['3.0']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- gemfiles/Gemfile-activemodel-6.0.x
- gemfiles/Gemfile-activemodel-6.1.x
- gemfiles/Gemfile-activemodel-7.0.x
- gemfiles/Gemfile-activemodel-7.1.x

name: Ruby ${{ matrix.ruby }} / Gemfile {{ matrix.gemfile }}

steps:
- uses: actions/checkout@v3
- name: Set up Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108

- name: Set up Ruby ${{ matrix.ruby }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
- name: Install dependencies for ${{ matrix.gemfile}}
run: bundle install --gemfile=${{ matrix.gemfile }}
ruby-version: ${{ matrix.ruby }}

- name: Install dependencies for ${{ matrix.gemfile }}
run: bundle install --gemfile=${{ matrix.gemfile }}

- name: Run tests
run: bundle exec rspec
5 changes: 0 additions & 5 deletions gemfiles/Gemfile-activemodel-6.0.x

This file was deleted.

2 changes: 1 addition & 1 deletion lib/sps_king/transaction.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def initialize(attributes = {})
self.requested_date ||= DEFAULT_REQUESTED_DATE
self.reference ||= 'NOTPROVIDED'
self.batch_booking = true if self.batch_booking.nil?
self.currency ||= 'EUR'
self.currency ||= 'CHF'
end

protected
Expand Down
Loading