Merge pull request #5 from viafintech/bug/use-correct-default-currency

Fix default currency on transactions
viafintech · Jun 20, 2024 · a7c4ac9 · a7c4ac9
2 parents 6087269 + a24c037
commit a7c4ac9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,21 +11,26 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
-        ruby-version: ['3.0']
+        ruby: ['3.0', '3.1', '3.2', '3.3']
         gemfile:
-          - gemfiles/Gemfile-activemodel-6.0.x
           - gemfiles/Gemfile-activemodel-6.1.x
           - gemfiles/Gemfile-activemodel-7.0.x
           - gemfiles/Gemfile-activemodel-7.1.x
 
+    name: Ruby ${{ matrix.ruby }} / Gemfile {{ matrix.gemfile }}
+
     steps:
       - uses: actions/checkout@v3
-      - name: Set up Ruby ${{ matrix.ruby-version }}
-        uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
+
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: ${{ matrix.ruby-version }}
-      - name: Install dependencies for ${{ matrix.gemfile}}
-        run: bundle install --gemfile=${{ matrix.gemfile  }}
+          ruby-version: ${{ matrix.ruby }}
+
+      - name: Install dependencies for ${{ matrix.gemfile }}
+        run: bundle install --gemfile=${{ matrix.gemfile }}
+
       - name: Run tests
         run: bundle exec rspec
diff --git a/gemfiles/Gemfile-activemodel-6.0.x b/gemfiles/Gemfile-activemodel-6.0.x
diff --git a/lib/sps_king/transaction.rb b/lib/sps_king/transaction.rb
@@ -43,7 +43,7 @@ def initialize(attributes = {})
       self.requested_date ||= DEFAULT_REQUESTED_DATE
       self.reference ||= 'NOTPROVIDED'
       self.batch_booking = true if self.batch_booking.nil?
-      self.currency ||= 'EUR'
+      self.currency ||= 'CHF'
     end
 
     protected