Error out before writing invalid rGFA tags #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennhickey
force-pushed
the
handle-stuff
branch
from
e732a76
to
719aa5d
Compare
|
@jeizenga Can you please hold off making the release until this is merged in ? should be done tests pretty soon I hope. |
|
Sure, no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rGFA doesn't support backwards steps.
vg convertchanged to throw an error if they are detected instead of silently producing invalid output. Paths can be changed to the forward orientation with clip-vg. This logic can be copied intovg pathsif there's demand for it.