Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subrange_of_matching_take lemma to seq_lib #1276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonhnet
Copy link
Collaborator

@jonhnet jonhnet commented Sep 20, 2024

Here's a lemma about Seq take and subrange I found valuable in verisplinter. I think it belongs in the seq library.

@jaybosamiya-ms
Copy link
Contributor

jaybosamiya-ms commented Sep 20, 2024

I was surprised by the sudden introduction of the additional newline (after the comment) to satisfy the formatter in your second commit (94676cf). Turns out this was a subtle weirdness (triggered by comments immediately after an assert ... by { ... } or similar block that doesn't require a semicolon after it before the next statement) that was introduced likely when adding support for clauses/stanzas. This is now fixed in verus-lang/verusfmt#89 and should hopefully soon be part of the next verusfmt release (EDIT: Released in v0.4.2), and the unnecessary newline should no longer be required by the formatter (you will be allowed to keep it if you like, but you will no longer be forced to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants