Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PeerConnection threads to nullptr when no PeerConnection::Options is passed to constructor #122

Closed
wants to merge 6 commits into from
Closed

Set PeerConnection threads to nullptr when no PeerConnection::Options is passed to constructor #122

wants to merge 6 commits into from

Commits on Jun 9, 2021

  1. Closing threads 

    When creating a new PeerConnection without a PeerConnectionFactory, network, signaling and worker threads are created.
After closing the peer connection, Handler will close those threads if they exist after receiving the OnSignalingChange for "close" state.
    @pablito25sp
    pablito25sp committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d48a07d View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Revert "Closing threads" 

    This reverts commit d48a07d.
    @pablito25sp
    pablito25sp committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    99a5e1d View commit details
    Browse the repository at this point in the history

  2. Setting threads to nullptr 

    When creating a new PeerConnection without PeerConnection::Options, set threads to nullptr so default destructor can take care of it on PeerConnection destruction.
    @pablito25sp
    pablito25sp committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    b0776a4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'versatica:v3' into v3

    @pablito25sp
    pablito25sp committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f1bb903 View commit details
    Browse the repository at this point in the history

  4. json dependency fix 

    See:
nlohmann/json#1971
nlohmann/json@e4d8dc0
    @pablito25sp
    pablito25sp committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0ce5e52 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Revert "json dependency fix" 

    This reverts commit 0ce5e52.
    @pablito25sp
    pablito25sp committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    f9450b5 View commit details
    Browse the repository at this point in the history