Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js example favicon #6367

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Update Next.js example favicon #6367

merged 1 commit into from
Jun 18, 2021

Conversation

pacocoursey
Copy link
Contributor

This updates the favicon from the outdated ZEIT logo to the new Vercel logo for the Next.js example.

Related Issues

vercel/next.js#26289

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #6367 (13a6797) into main (e659eec) will decrease coverage by 0.84%.
The diff coverage is n/a.

❗ Current head 13a6797 differs from pull request most recent head 004c0d4. Consider uploading reports for the commit 004c0d4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6367      +/-   ##
==========================================
- Coverage   13.09%   12.24%   -0.85%     
==========================================
  Files         273      273              
  Lines        9935     9813     -122     
  Branches     1373     1434      +61     
==========================================
- Hits         1301     1202      -99     
+ Misses       8549     8517      -32     
- Partials       85       94       +9     
Impacted Files Coverage Δ
src/util/dev/server.ts 49.00% <0.00%> (-3.94%) ⬇️
src/util/dev/builder-cache.ts 64.47% <0.00%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e659eec...004c0d4. Read the comment docs.

@pacocoursey pacocoursey marked this pull request as ready for review June 18, 2021 19:09
@TooTallNate TooTallNate merged commit 85fd2ae into main Jun 18, 2021
@TooTallNate TooTallNate deleted the paco/nextjs-favicon branch June 18, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants