Depend directly on swc crates #5879

kdy1 · 2023-09-05T16:54:11Z

Description

I'm profiling compile time difference of swc-project/swc#7911

Testing Instructions

Closes WEB-1499

Profile result

Original compile time: 2m 05s

New compile time: 2m 2s

vercel · 2023-09-05T16:54:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-cra-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 6:15am
examples-gatsby-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 6:15am
examples-svelte-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 6:15am

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Nov 10, 2023 6:15am

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

github-actions · 2023-09-05T16:59:11Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (linux)
Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-09-05T17:01:11Z

✅ This change can build next-swc

github-actions · 2023-09-05T18:11:47Z

Linux Benchmark for `7c446a2`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	989.55ms ± 0.64ms	997.82ms ± 3.12ms	+0.84%	+0.07%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	5880.77µs ± 19.50µs	5867.48µs ± 27.33µs	-0.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5373.29µs ± 22.67µs	5601.30µs ± 263.30µs	+4.24%
bench_startup/Turbopack CSR/1000 modules	989.55ms ± 0.64ms	997.82ms ± 3.12ms	+0.84%	+0.07%

github-actions · 2023-09-05T18:51:31Z

MacOS Benchmark for `7c446a2`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	10.44s ± 0.37s	4723.83ms ± 784.26ms	-54.77%	-35.17%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.89ms ± 0.06ms	27.74ms ± 0.05ms	-0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.18ms ± 0.09ms	26.88ms ± 0.35ms	-1.10%
bench_startup/Turbopack CSR/1000 modules	10.44s ± 0.37s	4723.83ms ± 784.26ms	-54.77%	-35.17%

github-actions · 2023-09-18T23:13:23Z

Linux Benchmark for `133e879`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5439.07µs ± 21.90µs	5454.74µs ± 31.83µs	+0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5028.28µs ± 20.76µs	5404.32µs ± 412.16µs	+7.48%
bench_startup/Turbopack CSR/1000 modules	987.35ms ± 0.95ms	986.68ms ± 3.09ms	-0.07%

github-actions · 2023-09-18T23:42:52Z

Linux Benchmark for `5aae0ce`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5846.49µs ± 77.31µs	5967.65µs ± 36.89µs	+2.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5356.02µs ± 40.72µs	5577.80µs ± 255.67µs	+4.14%
bench_startup/Turbopack CSR/1000 modules	1001.19ms ± 3.33ms	994.80ms ± 3.39ms	-0.64%

github-actions · 2023-09-19T00:24:20Z

MacOS Benchmark for `5aae0ce`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.62ms ± 0.06ms	27.99ms ± 0.03ms	+1.35%	+0.71%
bench_startup/Turbopack CSR/1000 modules	10.59s ± 2.30s	3444.53ms ± 55.46ms	-67.49%	-40.77%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.62ms ± 0.06ms	27.99ms ± 0.03ms	+1.35%	+0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.38ms ± 1.63ms	27.17ms ± 0.73ms	+16.18%
bench_startup/Turbopack CSR/1000 modules	10.59s ± 2.30s	3444.53ms ± 55.46ms	-67.49%	-40.77%

github-actions · 2023-11-10T03:00:30Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

kdy1 · 2023-11-10T06:30:50Z

Closing as it didn't have enough impact

github-actions · 2023-11-10T06:33:54Z

Linux Benchmark for `9a51c4e`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	21.86ms ± 0.88ms	21.67ms ± 0.86ms	-0.83%
bench_hmr_to_eval/Turbopack CSR/1000 modules	21.30ms ± 0.84ms	21.25ms ± 0.84ms	-0.27%
bench_startup/Turbopack CSR/1000 modules	1161.80ms ± 5.34ms	1214.40ms ± 27.05ms	+4.53%

kdy1 self-assigned this Sep 5, 2023

turbo-orchestrator bot added created-by: turbopack owned-by: turbopack labels Sep 5, 2023

orca-security-us bot reviewed Sep 5, 2023

View reviewed changes

turbo-orchestrator bot added the owned-by: turborepo label Sep 5, 2023

This was referenced Sep 5, 2023

Update swc_core to v0.83.0 vercel/next.js#55028

Closed

Update swc_core to v0.83.0 #5885

Closed

refactor: Depend directly on swc crates swc-project/plugins#208

Merged

kdy1 force-pushed the kdy1/direct-swc branch from db8ca37 to 2aea203 Compare September 18, 2023 13:03

turbo-orchestrator bot removed the owned-by: turborepo label Sep 18, 2023

kdy1 mentioned this pull request Oct 12, 2023

Make swc compile faster. swc-project/swc#7071

Closed

kdy1 added 3 commits November 10, 2023 11:55

Drop dep on swc_core

3eeb234

fixup

541aaf8

cargo lockfile

f854250

kdy1 force-pushed the kdy1/direct-swc branch from 246b33d to f854250 Compare November 10, 2023 02:56

turbo-orchestrator bot added the owned-by: turborepo label Nov 10, 2023

kdy1 added 5 commits November 10, 2023 12:04

Dep

c777ae7

cargo lockfile

d8d42bc

Patch some

a23d7a7

Patch some

40a9f79

Dep

1e2d496

kdy1 added 26 commits November 10, 2023 12:52

cargo lockfile

dfd3e97

fmt

951ef5c

Dep

e01070e

cargo lockfile

14cc0f7

Dep

a5b61a8

ㅊㅁㄱㅎ

453d49f

Fix

4ccb50c

Dep

3073132

fix

f4ddac3

Dep

0850841

fix

653bb2e

Dep

482867f

cargo lockfile

d7313b9

fix

8fdd86b

Dep

0af199c

cargo lockfile

32912e1

Dep

038235c

cargo lockfile

b2127ff

Dep

7dfeb89

Dep

a31f871

Dep

d83e7df

cargo lockfile

793b9c6

fix

4c5c15b

Dep

0465cf4

fi

3287a6b

cargo lockfile

eaddf6c

kdy1 closed this Nov 10, 2023

kdy1 deleted the kdy1/direct-swc branch January 29, 2024 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Depend directly on swc crates #5879

Depend directly on swc crates #5879

kdy1 commented Sep 5, 2023 •

edited

Loading

vercel bot commented Sep 5, 2023 •

edited

Loading

orca-security-us bot left a comment •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Nov 10, 2023 •

edited

Loading

kdy1 commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

Depend directly on swc crates #5879

Depend directly on swc crates #5879

Conversation

kdy1 commented Sep 5, 2023 • edited Loading

Description

Testing Instructions

Profile result

vercel bot commented Sep 5, 2023 • edited Loading

orca-security-us bot left a comment • edited Loading

Choose a reason for hiding this comment

Orca Security Scan Summary

github-actions bot commented Sep 5, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

Linux Benchmark for 7c446a2

github-actions bot commented Sep 5, 2023

MacOS Benchmark for 7c446a2

github-actions bot commented Sep 18, 2023

Linux Benchmark for 133e879

github-actions bot commented Sep 18, 2023

Linux Benchmark for 5aae0ce

github-actions bot commented Sep 19, 2023

MacOS Benchmark for 5aae0ce

github-actions bot commented Nov 10, 2023 • edited Loading

🟢 Turbopack Benchmark CI successful 🟢

kdy1 commented Nov 10, 2023

github-actions bot commented Nov 10, 2023

Linux Benchmark for 9a51c4e

kdy1 commented Sep 5, 2023 •

edited

Loading

vercel bot commented Sep 5, 2023 •

edited

Loading

orca-security-us bot left a comment •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

Linux Benchmark for `7c446a2`

MacOS Benchmark for `7c446a2`

Linux Benchmark for `133e879`

Linux Benchmark for `5aae0ce`

MacOS Benchmark for `5aae0ce`

github-actions bot commented Nov 10, 2023 •

edited

Loading

Linux Benchmark for `9a51c4e`