Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codemod): upgrade refactor #5279

Merged
merged 3 commits into from
Aug 8, 2023
Merged

feat(codemod): upgrade refactor #5279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1df5e12
feat(codemod): upgrade refactor
tknickman Jun 13, 2023
413160b
extend if check
tknickman Aug 8, 2023
8d73aa8
update jest config
tknickman Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions packages/create-turbo/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,9 @@ describe("create-turbo", () => {
const mockAvailablePackageManagers = jest
.spyOn(turboUtils, "getAvailablePackageManagers")
.mockResolvedValue({
npm: {
available: true,
version: "8.19.2",
},
yarn: {
available: true,
version: "1.22.10",
},
pnpm: {
available: true,
version: "7.22.2",
},
npm: "8.19.2",
yarn: "1.22.10",
pnpm: "7.22.2",
});

const mockCreateProject = jest
Expand Down
6 changes: 5 additions & 1 deletion packages/create-turbo/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ module.exports = {
testEnvironment: "node",
testPathIgnorePatterns: ["/__fixtures__/", "/__tests__/test-utils.ts"],
coveragePathIgnorePatterns: ["/__fixtures__/", "/__tests__/test-utils.ts"],
transformIgnorePatterns: ["/node_modules/(?!(ansi-regex)/)"],
transformIgnorePatterns: [
"node_modules/*",
"packages/turbo-utils/*",
"packages/turbo-workspaces/*",
],
modulePathIgnorePatterns: ["<rootDir>/node_modules", "<rootDir>/dist"],
collectCoverage: true,
verbose: process.env.RUNNER_DEBUG === "1",
Expand Down
4 changes: 2 additions & 2 deletions packages/create-turbo/src/commands/create/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export async function create(
skipTransforms || !selectedPackageManagerDetails
? {
name: project.packageManager,
version: availablePackageManagers[project.packageManager].version,
version: availablePackageManagers[project.packageManager],
}
: selectedPackageManagerDetails;

Expand Down Expand Up @@ -173,7 +173,7 @@ export async function create(
// before we attempt an install
if (
opts.skipTransforms &&
!availablePackageManagers[project.packageManager].available
!availablePackageManagers[project.packageManager]
) {
warn(
`Unable to install dependencies - "${exampleName}" uses "${project.packageManager}" which could not be found.`
Expand Down
6 changes: 3 additions & 3 deletions packages/create-turbo/src/commands/create/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ export async function packageManager({
// prompt for package manager if it wasn't provided as an argument, or if it was
// provided, but isn't available (always allow npm)
!packageManager ||
!availablePackageManagers?.[packageManager as PackageManager]?.available,
!availablePackageManagers?.[packageManager as PackageManager],
choices: ["npm", "pnpm", "yarn"].map((p) => ({
name: p,
value: p,
disabled: availablePackageManagers?.[p as PackageManager]?.available
disabled: availablePackageManagers?.[p as PackageManager]
? false
: `not installed`,
})),
Expand All @@ -72,6 +72,6 @@ export async function packageManager({

return {
name: selectedPackageManager,
version: availablePackageManagers[selectedPackageManager].version,
version: availablePackageManagers[selectedPackageManager],
};
}
Loading
Loading