-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict Environment Handling #4449
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e928702
First draft.
nathanhammond 45fb7da
incremental
nathanhammond abc01a2
Source data from turbo.json instead.
nathanhammond 5958ed3
Tests for the Go parsing.
nathanhammond 6fb240b
Test for globalPassthroughEnv
nathanhammond da5ac59
Consider the infer variable in the hash.
nathanhammond f45227e
add integration test
nathanhammond 1dde429
more testing
nathanhammond bf3f7e6
Merge branch 'main' into opt-in-env
mehulkar c2c5e67
Avoid global hash changes, update tests and refactor
mehulkar e7cfe6a
Merge branch 'main' into opt-in-env
mehulkar 2357746
Match casing in key name
mehulkar c946929
Ensure systemroot is made available in all modes
mehulkar 92e9fd3
Remove docs for this PR
mehulkar 61e3f1b
revert schema docs
mehulkar 65f35e9
make test work in ci
mehulkar 571f291
rm test for shell being set in task process, not working in ci
mehulkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
cli/integration_tests/strict_env_vars/fixture-configs/all.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"], | ||
"experimentalPassThroughEnv": ["LOCAL_VAR_PT"], | ||
"env": ["LOCAL_VAR_DEP"] | ||
} | ||
}, | ||
"experimentalGlobalPassThroughEnv": ["GLOBAL_VAR_PT"], | ||
"globalEnv": ["GLOBAL_VAR_DEP"] | ||
} |
9 changes: 9 additions & 0 deletions
9
cli/integration_tests/strict_env_vars/fixture-configs/global_pt-empty.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"] | ||
} | ||
}, | ||
"experimentalGlobalPassThroughEnv": [] | ||
} |
9 changes: 9 additions & 0 deletions
9
cli/integration_tests/strict_env_vars/fixture-configs/global_pt.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"] | ||
} | ||
}, | ||
"experimentalGlobalPassThroughEnv": ["GLOBAL_VAR_PT"] | ||
} |
9 changes: 9 additions & 0 deletions
9
cli/integration_tests/strict_env_vars/fixture-configs/task_pt-empty.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"], | ||
"experimentalPassthroughEnv": [] | ||
} | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
cli/integration_tests/strict_env_vars/fixture-configs/task_pt.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"], | ||
"experimentalPassthroughEnv": ["LOCAL_VAR_PT"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
|
||
# This script greps stdin (i.e. what's piped to it) | ||
# splits it by "=" and prints the second value. | ||
# it's intendted to get the global hash from a debug log that looks like this: | ||
# 2023-04-06T04:28:19.599Z [DEBUG] turbo: global hash: value=a027dadc4dea675e | ||
# | ||
# Usage: | ||
# turbo build -vv 2>&1 | "$TESTDIR/./get-global-hash.sh" | ||
# | ||
# | ||
grep "global hash:" - | awk '{split($0,a,"="); print a[2]}' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode=infer | ||
|
||
Baseline global hash | ||
$ BASELINE=$(${TURBO} build -vv 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
|
||
There's no config to start, so the global hash does not change when flag is passed | ||
$ WITH_FLAG=$(${TURBO} build -vv --experimental-env-mode=infer 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE = $WITH_FLAG | ||
|
||
Add empty config for global pass through env var, global hash changes | ||
$ cp "$TESTDIR/fixture-configs/global_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_EMPTY_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=infer 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE != $WITH_EMPTY_GLOBAL | ||
|
||
Add global pass through env var, global hash changes again, because we changed the value | ||
$ cp "$TESTDIR/fixture-configs/global_pt.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=infer 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_EMPTY_GLOBAL != $WITH_GLOBAL |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode=loose | ||
|
||
Baseline global hash | ||
$ BASELINE=$(${TURBO} build -vv 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
|
||
Hash changes, because we're using a new mode | ||
$ WITH_FLAG=$(${TURBO} build -vv --experimental-env-mode=loose 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE != $WITH_FLAG | ||
|
||
Add empty config for global pass through env var | ||
Hash does not change, because in loose mode, we don't care what the actual config contains | ||
$ cp "$TESTDIR/fixture-configs/global_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_EMPTY_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=loose 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_FLAG = $WITH_EMPTY_GLOBAL | ||
|
||
Add global pass through env var | ||
Hash does not change, because in loose mode, we don't care what the actual config contains | ||
$ cp "$TESTDIR/fixture-configs/global_pt.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=loose 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_FLAG = $WITH_GLOBAL | ||
$ test $WITH_EMPTY_GLOBAL = $WITH_GLOBAL |
22 changes: 22 additions & 0 deletions
22
cli/integration_tests/strict_env_vars/global_hash_no-value.t
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode (should be the same as --experimental-env-mode=infer) | ||
|
||
Baseline global hash | ||
$ BASELINE=$(${TURBO} build -vv 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
|
||
There's no config to start, so the global hash does not change when flag is passed | ||
$ WITH_FLAG=$(${TURBO} build -vv --experimental-env-mode 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE = $WITH_FLAG | ||
|
||
Add empty config for global pass through env var, global hash changes | ||
$ cp "$TESTDIR/fixture-configs/global_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_EMPTY_GLOBAL=$(${TURBO} build -vv --experimental-env-mode 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE != $WITH_EMPTY_GLOBAL | ||
|
||
Add global pass through env var, global hash changes again, because we changed the value | ||
$ cp "$TESTDIR/fixture-configs/global_pt.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_GLOBAL=$(${TURBO} build -vv --experimental-env-mode 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_EMPTY_GLOBAL != $WITH_GLOBAL |
24 changes: 24 additions & 0 deletions
24
cli/integration_tests/strict_env_vars/global_hash_strict.t
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With strict mode | ||
|
||
Get Baseline global hash | ||
$ BASELINE=$(${TURBO} build -vv 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
|
||
Hash changes, because we're using a new mode | ||
$ WITH_FLAG=$(${TURBO} build -vv --experimental-env-mode=strict 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $BASELINE != $WITH_FLAG | ||
|
||
Add empty config for global pass through env var | ||
Hash does not change, because the mode is the same and we haven't added any new pass through vars | ||
$ cp "$TESTDIR/fixture-configs/global_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_EMPTY_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=strict 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_FLAG = $WITH_EMPTY_GLOBAL | ||
|
||
Add global pass through env var | ||
Hash changes, because we have a new pass through value | ||
$ cp "$TESTDIR/fixture-configs/global_pt.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ WITH_GLOBAL=$(${TURBO} build -vv --experimental-env-mode=strict 2>&1 | "$TESTDIR/./get-global-hash.sh") | ||
$ test $WITH_EMPTY_GLOBAL != $WITH_GLOBAL |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules/ | ||
.turbo | ||
.npmrc | ||
out.txt |
22 changes: 22 additions & 0 deletions
22
cli/integration_tests/strict_env_vars/monorepo/apps/my-app/build.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
#!/bin/bash | ||
|
||
pathset="no" | ||
sysrootset="no" | ||
|
||
if [ ! -z "$PATH" ]; then | ||
pathset="yes" | ||
fi | ||
|
||
if [ ! -z "$SYSTEMROOT" ]; then | ||
sysrootset="yes" | ||
fi | ||
|
||
{ | ||
echo -n "globalpt: '$GLOBAL_VAR_PT', " | ||
echo -n "localpt: '$LOCAL_VAR_PT', " | ||
echo -n "globaldep: '$GLOBAL_VAR_DEP', " | ||
echo -n "localdep: '$LOCAL_VAR_DEP', " | ||
echo -n "other: '$OTHER_VAR', " | ||
echo -n "sysroot set: '$sysrootset', " | ||
echo "path set: '$pathset'" | ||
} > out.txt |
6 changes: 6 additions & 0 deletions
6
cli/integration_tests/strict_env_vars/monorepo/apps/my-app/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"name": "my-app", | ||
"scripts": { | ||
"build": "./build.sh" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"name": "monorepo", | ||
"workspaces": [ | ||
"apps/**" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"pipeline": { | ||
"build": { | ||
"outputs": ["dist/**"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/bin/bash | ||
|
||
SCRIPT_DIR=$(dirname ${BASH_SOURCE[0]}) | ||
TARGET_DIR=$1 | ||
FIXTURE=$2 | ||
|
||
cp -a ${SCRIPT_DIR}/$2/. ${TARGET_DIR}/ | ||
${SCRIPT_DIR}/../setup_git.sh ${TARGET_DIR} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode=infer | ||
|
||
Set the env vars | ||
$ export GLOBAL_VAR_PT=higlobalpt | ||
$ export GLOBAL_VAR_DEP=higlobaldep | ||
$ export LOCAL_VAR_PT=hilocalpt | ||
$ export LOCAL_VAR_DEP=hilocaldep | ||
$ export OTHER_VAR=hiother | ||
|
||
Conditionally set these vars if they aren't already there for the purpose of the test. | ||
The test doesn't care about the values, it just checks that the var is available to the task | ||
so we just have to make sure the parent process has them set. In Github CI, for example SHELL | ||
isn't already set. | ||
$ export SYSTEMROOT="${SYSTEMROOT:=hisysroot}" | ||
$ export PATH="${PATH:=hipath}" | ||
|
||
Inferred mode as loose because no pass through configs, all vars are available | ||
$ ${TURBO} build -vv --experimental-env-mode=infer > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: 'higlobalpt', localpt: 'hilocalpt', globaldep: 'higlobaldep', localdep: 'hilocaldep', other: 'hiother', sysroot set: 'yes', path set: 'yes' | ||
|
||
Inferred mode as strict, because global pass through config, no vars available | ||
$ cp "$TESTDIR/fixture-configs/global_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ ${TURBO} build -vv --experimental-env-mode=infer > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: '', localpt: '', globaldep: '', localdep: '', other: '', sysroot set: 'yes', path set: 'yes' | ||
|
||
Inferred mode as strict, because task pass through config, no vars available | ||
$ cp "$TESTDIR/fixture-configs/task_pt-empty.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ ${TURBO} build -vv --experimental-env-mode=infer > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: '', localpt: '', globaldep: '', localdep: '', other: '', sysroot set: 'yes', path set: 'yes' | ||
|
||
Inferred mode as strict, with declared deps and pass through. all declared available, other is not available | ||
$ cp "$TESTDIR/fixture-configs/all.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ ${TURBO} build -vv --experimental-env-mode=infer > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: 'higlobalpt', localpt: 'hilocalpt', globaldep: 'higlobaldep', localdep: 'hilocaldep', other: '', sysroot set: 'yes', path set: 'yes' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode=loose, all vars are available | ||
|
||
Set the env vars | ||
$ export GLOBAL_VAR_PT=higlobalpt | ||
$ export GLOBAL_VAR_DEP=higlobaldep | ||
$ export LOCAL_VAR_PT=hilocalpt | ||
$ export LOCAL_VAR_DEP=hilocaldep | ||
$ export OTHER_VAR=hiother | ||
$ export SYSTEMROOT=hisysroot | ||
|
||
All vars available in loose mode | ||
$ ${TURBO} build -vv --experimental-env-mode=loose > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: 'higlobalpt', localpt: 'hilocalpt', globaldep: 'higlobaldep', localdep: 'hilocaldep', other: 'hiother', sysroot set: 'yes', path set: 'yes' | ||
|
||
All vars available in loose mode, even when global and pass through configs defined | ||
$ cp "$TESTDIR/fixture-configs/all.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ ${TURBO} build -vv --experimental-env-mode=loose > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: 'higlobalpt', localpt: 'hilocalpt', globaldep: 'higlobaldep', localdep: 'hilocaldep', other: 'hiother', sysroot set: 'yes', path set: 'yes' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
Setup | ||
$ . ${TESTDIR}/../setup.sh | ||
$ . ${TESTDIR}/setup.sh $(pwd) monorepo | ||
|
||
With --experimental-env-mode=strict, only declared vars are available | ||
|
||
Set the env vars | ||
$ export GLOBAL_VAR_PT=higlobalpt | ||
$ export GLOBAL_VAR_DEP=higlobaldep | ||
$ export LOCAL_VAR_PT=hilocalpt | ||
$ export LOCAL_VAR_DEP=hilocaldep | ||
$ export OTHER_VAR=hiother | ||
$ export SYSTEMROOT=hisysroot | ||
|
||
No vars available by default | ||
$ ${TURBO} build -vv --experimental-env-mode=strict > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: '', localpt: '', globaldep: '', localdep: '', other: '', sysroot set: 'yes', path set: 'yes' | ||
|
||
All declared vars available, others are not available | ||
$ cp "$TESTDIR/fixture-configs/all.json" "$(pwd)/turbo.json" && git commit -am "no comment" --quiet | ||
$ ${TURBO} build -vv --experimental-env-mode=strict > /dev/null 2>&1 | ||
$ cat apps/my-app/out.txt | ||
globalpt: 'higlobalpt', localpt: 'hilocalpt', globaldep: 'higlobaldep', localdep: 'hilocaldep', other: '', sysroot set: 'yes', path set: 'yes' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't possible to hide flags from the usage message