-
Notifications
You must be signed in to change notification settings - Fork 1.8k
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[turborepo] Prune is no longer copying package.json to full
directory
#5768
Comments
full
directory
Thanks for the issue, #5769 should fix it. |
Nice. Currently I also need to copy over the It looks like I also just noticed that in either versions the |
I'd be open to look into if we could copy over I don't think that there's platform dependent code in |
That sounds good. And I'll look at explicitly calling I just need the I'm fine copying the files over manually for my setup though. |
### Description Fixes #5768 We were copying the root `package.json` into `out` and not `out/full` as intended if the `--docker` flag was used. This behavior would only appear if the root `package.json` contained patches the needed to be pruned. This PR gets us back to the Go behavior. ### Testing Instructions Started also tracking the contents of `out/full` in an integration test Closes TURBO-1227 --------- Co-authored-by: Chris Olszewski <Chris Olszewski>
What version of Turborepo are you using?
1.10.10
What package manager are you using / does the bug impact?
Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
Running
turbo prune --scope=X --docker
properly pairs down the list of packages, however the rootpackage.json
doesn't seem to be copied into thefull
folder.This causes
yarn
to think that there are 0 packages and it generates an empty lock file.According to the docs, there should be a
package.json
in thefull
directory.https://turbo.build/repo/docs/reference/command-line-reference/prune#--docker
Expected Behavior
Copy the
package.json
into thefull
directory as well as thejson
directoryTo Reproduce
root
directoryjson
directoryfull
directoryWith 1.10.9
root
directoryjson
directoryfull
directoryReproduction Repo
No response
The text was updated successfully, but these errors were encountered: