Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new 'args' config #37

Closed
wants to merge 13 commits into from
Closed

Adding new 'args' config #37

wants to merge 13 commits into from

Commits on Oct 29, 2019

  1. Adding new 'args' config 

    Adds the ability to pass arguments to the fetcher function

- [x] Updated documentation
- [x] Added example
- [x] Added test
    @cryptiklemur
    cryptiklemur committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    9072ff6 View commit details
    Browse the repository at this point in the history

  2. Fixing lint issue

    @cryptiklemur
    cryptiklemur committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    1de5548 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Adding fn and fetcherArgs to deps

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    a83fdfc View commit details
    Browse the repository at this point in the history

  2. Adding deps arg

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    f854e4a View commit details
    Browse the repository at this point in the history

  3. Fixing readme and example

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    a297411 View commit details
    Browse the repository at this point in the history

  4. Fixing readme

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    56e4943 View commit details
    Browse the repository at this point in the history

  5. Adding promise on possible return types for fetcherFn

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    487f75a View commit details
    Browse the repository at this point in the history

  6. Need to type config fetcher

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    d7c13fa View commit details
    Browse the repository at this point in the history

  7. Need to type config fetcher for overrides

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    c78a2df View commit details
    Browse the repository at this point in the history

  8. Lint fixes

    @cryptiklemur
    cryptiklemur committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    7e9a55a View commit details
    Browse the repository at this point in the history

  9. Update examples/fetch-with-credentials/package.json 

    Co-Authored-By: Shu Ding <ds303077135@gmail.com>
    @cryptiklemur @shuding
    cryptiklemur and shuding committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    7017b92 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-Authored-By: Shu Ding <ds303077135@gmail.com>
    @cryptiklemur @shuding
    cryptiklemur and shuding committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    c79be79 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Updating fetcherArgs to be key if not set

    @cryptiklemur
    cryptiklemur committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    353f9a2 View commit details
    Browse the repository at this point in the history