Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: imporve dynamic polling interval test #351

Merged
merged 1 commit into from
Apr 22, 2020
Merged

test: imporve dynamic polling interval test #351

merged 1 commit into from
Apr 22, 2020

Conversation

promer94
Copy link
Collaborator

make sure polling stop when refreshInterval is 0

@promer94
Copy link
Collaborator Author

Hi @shuding
Could you please review this
I don't know why you are not in the reviewers

shuding
shuding approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you @promer94 :)

(It turns out I forgot to update my username)

@shuding shuding merged commit 94f1c88 into vercel:master Apr 22, 2020
@promer94 promer94 deleted the improve-test branch May 3, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@promer94 @shuding