Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use window as a target for online event #300

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Use window as a target for online event #300

merged 1 commit into from
Mar 13, 2020

Conversation

nulladdict
Copy link
Contributor

@nulladdict nulladdict commented Mar 12, 2020 •
edited
Loading

Also fix unsubscribe callback assignment

Closes #301

@nulladdict nulladdict mentioned this pull request Mar 12, 2020
Closed
shuding
shuding approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you resolve the conflicts? I merged the other PR 😅

@nulladdict
Use window as a target for online event
6d02976 
Also fix unsubscribe callback assignment
@nulladdict
Copy link
Contributor Author

Sure thing, I've resolved the conflicts

@shuding
Copy link
Member

shuding commented Mar 13, 2020

Thanks @nulladdict !

@shuding shuding merged commit ec6c31c into vercel:master Mar 13, 2020
@nulladdict nulladdict deleted the online-event branch March 13, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit target for online event
2 participants
@nulladdict @shuding