fix: Improve comparison performance #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
cramforce
approved these changes
May 31, 2024
kimdaeyeub
pushed a commit
to kimdaeyeub/swr
that referenced
this pull request
Jun 21, 2024
use deep comparison instead of hashing the fetch body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using the
stableHashutility (that we use for hashing resource keys) to handle the deep comparison task which is a great code reuse. However, in the worse case it might be a performance bottleneck when the payload is a large object but different from the previous data, as comparison cannot be done during the traversal.This PR re-introduces
dequal/liteas a dependency and uses that for comparison instead.