Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling of client entry chunks #2932

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Fix bundling of client entry chunks #2932

merged 2 commits into from
Apr 6, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 6, 2024

Last beta release breaks SWRConfig on the server layer. If you import { SWRConfig } from "swr" inside a Server Component, it will go through these import paths infinitely:

swr/dist/core/react-server.mjs
export { SWRConfig } from 'swr/_internal';
swr/dist/_internal/react-server.mjs
export { SWRConfig } from 'swr/_internal';
repeat…

Reverting swr config to previous change and add an e2e test for it

@huozhi huozhi requested a review from shuding as a code owner April 6, 2024 15:54
Copy link

codesandbox-ci bot commented Apr 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

socket-security bot commented Apr 6, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/next@14.1.0

View full report↗︎

@shuding shuding changed the title Fix promise fallback data Fix bundling of client entry chunks Apr 6, 2024
@shuding shuding merged commit f59b7c8 into main Apr 6, 2024
7 checks passed
@shuding shuding deleted the fix/import-swr-config branch April 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants