Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify test coverage strategy #2909

Merged
merged 4 commits into from
Mar 10, 2024
Merged

chore: simplify test coverage strategy #2909

merged 4 commits into from
Mar 10, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 9, 2024 •
edited
Loading

Follow up of #2903

  • Use separate test job to coverage legacy react build (react 17)
  • Ignore env.ts since it's not necessary to be covered

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 9, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@huozhi huozhi marked this pull request as ready for review March 9, 2024 22:01
@huozhi huozhi requested a review from shuding as a code owner March 9, 2024 22:01
@huozhi huozhi marked this pull request as draft March 9, 2024 22:22
@huozhi huozhi marked this pull request as ready for review March 9, 2024 22:33
@huozhi huozhi merged commit 9e5eec2 into main Mar 10, 2024
7 checks passed
@huozhi huozhi deleted the test/test-coverage branch March 10, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huozhi @shuding