Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #215 #216

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Fix #215 #216

merged 1 commit into from
Dec 30, 2019

Conversation

vassbence
Copy link
Contributor

No description provided.

shuding
shuding approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vassbence !

@shuding shuding merged commit 36eb040 into vercel:master Dec 30, 2019
@vassbence vassbence mentioned this pull request Dec 30, 2019
Closed
@IanBurgan IanBurgan mentioned this pull request Oct 28, 2020
Merged
pacocoursey pushed a commit to vercel/swr-site that referenced this pull request Oct 28, 2020
@IanBurgan
Update to be consistent with other examples (#42)
c11aa97 
As described here: vercel/swr#215 and later fixed here: vercel/swr#216
I discovered this after getting confused about whether to await before returning or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vassbence @shuding