Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: drop the default fetcher #1304

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Breaking: drop the default fetcher #1304

merged 2 commits into from
Jul 21, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 21, 2021

Resolves #1244

@huozhi huozhi requested a review from shuding as a code owner July 21, 2021 04:39
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71c14bf:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration
SWR Issue Repro (undefined fetcher) Issue #1244

shuding
shuding reviewed Jul 21, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s also add a test case that uses SWR to share local state?

@shuding shuding changed the title Drop default fetcher Breaking: drop the default fetcher Jul 21, 2021
shuding
shuding approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuding shuding merged commit 124b5d2 into master Jul 21, 2021
@shuding shuding deleted the drop-default-fetcher branch July 21, 2021 09:22
@shuding shuding added this to the 1.0 milestone Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

If a fetcher isn't defined, useSWR shouldn't fetch
2 participants
@huozhi @shuding