-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine createCache #1283
Merged
Merged
Refine createCache #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b84215b:
|
huozhi
force-pushed
the
fix/revalidteonfocus-cache
branch
from
July 10, 2021 12:40
9d56c96
to
e6d1b21
Compare
shuding
requested changes
Jul 10, 2021
huozhi
commented
Jul 10, 2021
shuding
reviewed
Jul 15, 2021
shuding
reviewed
Jul 15, 2021
I pushed a change due to one comment ☝️ , let me know what do you think! |
huozhi
force-pushed
the
fix/revalidteonfocus-cache
branch
from
July 16, 2021 07:28
17e8792
to
2674fdc
Compare
force pushed it but honored your changes @shuding |
shuding
reviewed
Jul 17, 2021
shuding
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
Changes
setupOn<Event>
for cachecreateCache
Fixes
focus
,reconnect
events on web