Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readme #104

Merged
merged 6 commits into from
Nov 11, 2019
Merged

Improve readme #104

merged 6 commits into from
Nov 11, 2019

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 9, 2019 •
edited
Loading

sergiodxa
sergiodxa reviewed Nov 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@shuding @sergiodxa
Update README.md
196d90d 
Co-Authored-By: Sergio Xalambrí <hello@sergiodxa.com>
@shuding shuding marked this pull request as ready for review November 11, 2019 19:42
pacocoursey
pacocoursey suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good 😌

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shuding @pacocoursey
Apply suggestions from code review
b26a920 
Co-Authored-By: Paco <34928425+pacocoursey@users.noreply.github.com>
pacocoursey
pacocoursey suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo in the Data Fetching example:

You can use any library you to handle data fetching, for example:
You can use any library to handle data fetching, for example:

@pacocoursey pacocoursey merged commit 8060589 into master Nov 11, 2019
@pacocoursey pacocoursey deleted the improve-readme branch November 11, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa left review comments

@pacocoursey pacocoursey pacocoursey approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention React Native support on readme
3 participants
@shuding @sergiodxa @pacocoursey