Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable typescript strict mode #1010

Merged
merged 6 commits into from
Mar 9, 2021
Merged

enable typescript strict mode #1010

merged 6 commits into from
Mar 9, 2021

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented Mar 5, 2021

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 5, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 512a348:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration

huozhi
huozhi reviewed Mar 5, 2021
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
@koba04
Copy link
Collaborator

koba04 commented Mar 5, 2021

Great work! I prefer @ts-expect-error to @ts-ignore, but the version SWR uses doesn't support it, so it would be great if it is replaced after updating the version.

shuding
shuding reviewed Mar 7, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking great, nice work! 🎉

I might ship #1016 before this one, because the types are broken in the current beta release. But I think there won’t be too many conflicts.

src/index.ts Outdated Show resolved Hide resolved
@promer94 promer94 requested review from shuding and huozhi March 9, 2021 09:36
shuding
shuding approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🎉 🎉

@shuding shuding merged commit 158792a into vercel:master Mar 9, 2021
@promer94 promer94 deleted the strict-ts branch March 9, 2021 12:22
This was referenced Mar 9, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
@NOUIY NOUIY mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@promer94 @koba04 @shuding @huozhi