Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utilities/cli): use chalk-template to render help message #713

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

gamemaker1
Copy link
Contributor

@gamemaker1 gamemaker1 commented Jul 13, 2022

Related Issues

Closes #711.

Description

  • adds chalk-template as a dependency
  • uses chalk-template for rendering the help message in source/utilities/cli.ts

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leerob leerob merged commit 3fbca73 into vercel:main Jul 13, 2022
@leerob
Copy link
Member

leerob commented Jul 14, 2022

CleanShot 2022-07-13 at 21 25 57@2x

Seems like a bug that it's telling me to update on latest as well.

@leerob
Copy link
Member

leerob commented Jul 14, 2022

Snapshot tests will help here :)

@gamemaker1
Copy link
Contributor Author

Seems like a bug that it's telling me to update on latest as well.

Are you sure the globally installed serve is the latest version? If it were on the latest version, then the update message's formatting would not be broken.

@gamemaker1 gamemaker1 deleted the fix/use-chalk-template branch July 14, 2022 09:56
@leerob
Copy link
Member

leerob commented Jul 14, 2022

CleanShot 2022-07-14 at 08 46 42@2x

Weird... maybe my npm global install didn't work last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update message has malformed chalk output
2 participants