This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
Fix pkg example express app #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, following the instructions provided in the README result in pkg failing to build the executable. The error output references "node7" as being an undefined target in package.json. pkg relies on pkg-fetch for retrieving Node versions to be used as targets in building executables. As of pkg-fetch v2.5, no node v7.x.x is listed as an available source. Changing "node7" to "node10" fixes this issue as it is available via pkg-fetch v2.5. Additionally, this PR: *) Adds files/folders to .gitignore related to the example express app which should not be included in master. *) Improves README ducumentation for example express app.
Changed `pkg` target from `node10` to `node8` in order to pass CI build errors due to missing peer dependency for babel at that version.
|
@igorklopov @leo Not sure what's causing the build errors. You both have contributed the most to this project. Any thoughts? Could be over looking something obvious. |
igorklopov
approved these changes
Apr 27, 2019
|
Thanks! |
|
Np |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Currently, following the instructions provided in the
READMEresult inpkgfailing to build the executable. The error output referencesnode7as being an undefinedtargetinpackage.json.The Solution
pkgrelies onpkg-fetchfor retrieving Node versions to be used astargetsin building executables. As ofpkg-fetchv2.5, nonodev7.x.x is listed as an available source. Changingnode7tonode10fixes this issue as it is available viapkg-fetchv2.5.Additionally, this PR